Removing docker.userEmulation from config #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
docker.userEmulation
is no longer supported from nextflow 24.01.0.There was some discussion on what to do about this here:
https://nextflow.slack.com/archives/C02T98A23U7/p1709049357728229
It looks like our options are to either remove it or to add settings similar to what
docker.userEmulation
achieved viadocker.runOptions
orprocess.containerOptions
(less desirable).According to https://nextflow.slack.com/archives/C02T98A23U7/p1696591307155289?thread_ts=1696590982.727319&cid=C02T98A23U7, it apparently used to add the following arguments to the docker invocation:
I'm suggesting that we just remove it in the hope that it was never truly required by any of our pipelines. That said, according to the discussions above, it could be that
GATK
requires:So we might need to test with a pipeline that users GATK if we want to be more confident that it's not required for that.