Feature/add support for third party templating #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This deprecates the `useSanityClient` hook and exposes `sanityClient` on the 'sanity:client' module
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started digging into #59 and noticed that we could simplify the developer experience of this plugin and bring it closer to the Astro conventions:
Removes the useSanityClient() hook. It caused problems when imported into client-side non-Astro files
Introduces the import { sanityClient } from 'sanity:client' pattern, which works across .astro and non-.astro files
Adds a JSX component with client-side data-fetching to the example
This is a breaking change since it deprecates the useSanityClient hook.
Some commits in this PR intentionally don't follow Vite plugin conventions in favor of adopting Astro integration conventions.
I think I managed to include typing support for the modules, but that is a thing to double-check.