-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): allow locale plugins to translate "All fields" field group #7117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
rexxars
changed the title
Fix/i18n all fields title
fix(i18n): allow locale packs to translate "All fields" field group
Jul 9, 2024
rexxars
changed the title
fix(i18n): allow locale packs to translate "All fields" field group
fix(i18n): allow locale plugins to translate "All fields" field group
Jul 9, 2024
No changes to documentation |
Component Testing Report Updated Jul 10, 2024 3:57 PM (UTC)
|
rexxars
force-pushed
the
fix/i18n-all-fields-title
branch
from
July 10, 2024 15:42
cdbeb4d
to
6ab6c18
Compare
cngonzalez
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me, thank you!
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "All fields" field group is currently not translatable - this is an oversight on our part.
This PR allows field groups the ability to specify i18n titles, in the same way that certain other schema level properties can (sort orders, for instance).
Additionally, it introduces a new i18n key:
inputs.object.field-group-tabs.all-fields-title
- which is used by the default "All fields" group.What to review
🇺🇸 Group 1
(translated throughi18n.title
),intentionally-missing-key
(defined throughi18n.title
, but does not exist, ergo not translated) and🌐 Non-i18n group
(title set directly ontitle
property, no i18n in play)Testing
Added basic e2e tests that show the expected outcome on the i18n field group debug schema test.
Notes for release
None, for now. Since users cannot currently switch between locales, it makes more sense to wait to document this when we do allow users to switch. Right now it is easier to just define the localized title straight on the
title
property.This still has value for locale packs, but those should automatically pick up and AI-translate the "All fields" group after release.