test(sanity): migrate sanity package to vitest #7578

binoy14 · 2024-10-03T17:34:11Z

Description

Migrates sanity tests to vitest

What to review

Changes makes sense and all tests pass

Testing

All tests should pass

Notes for release

N/A

vercel · 2024-10-03T17:34:17Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 14, 2024 1:06pm
performance-studio	✅ Ready (Inspect)	Visit Preview		Oct 14, 2024 1:06pm
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 14, 2024 1:06pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 14, 2024 1:06pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 14, 2024 1:06pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 14, 2024 1:06pm

binoy14 · 2024-10-03T17:34:27Z

test(sanity): migrate more packages to vitest #7573
chore(test): move @sanity/block-tools to vitest #7579
test(sanity): migrate sanity package to vitest #7578 👈
next

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @binoy14 and the rest of your teammates on Graphite

github-actions · 2024-10-03T17:35:01Z

No changes to documentation

github-actions · 2024-10-03T18:01:17Z

Component Testing Report Updated Oct 14, 2024 1:54 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	43s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	8s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	31s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	39s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	11s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	45s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 41s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 16s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	8s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	27s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	36s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-03T18:05:21Z

⚡️ Editor Performance Report

Updated Mon, 14 Oct 2024 14:05:46 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	17.9 efps (56ms)	17.7 efps (57ms)	+1ms (+0.9%)	✅
article (body)	53.1 efps (19ms)	56.2 efps (18ms)	-1ms (-5.6%)	✅
article (string inside object)	17.9 efps (56ms)	18.5 efps (54ms)	-2ms (-3.6%)	✅
article (string inside array)	14.3 efps (70ms)	14.5 efps (69ms)	-1ms (-1.4%)	✅
recipe (name)	31.3 efps (32ms)	29.9 efps (34ms)	+2ms (+4.7%)	✅
recipe (description)	35.1 efps (29ms)	33.3 efps (30ms)	+2ms (+5.3%)	✅
recipe (instructions)	99.9+ efps (7ms)	99.9+ efps (7ms)	+0ms (-/-%)	✅
synthetic (title)	14.9 efps (67ms)	15.4 efps (65ms)	-2ms (-3.0%)	✅
synthetic (string inside object)	16.3 efps (62ms)	15.9 efps (63ms)	+2ms (+2.4%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	56ms	63ms	82ms	212ms	1508ms	14.2s
article (body)	19ms	24ms	66ms	305ms	481ms	7.3s
article (string inside object)	56ms	61ms	71ms	287ms	1369ms	10.0s
article (string inside array)	70ms	76ms	100ms	283ms	1970ms	10.7s
recipe (name)	32ms	34ms	37ms	109ms	86ms	8.9s
recipe (description)	29ms	30ms	33ms	106ms	65ms	6.3s
recipe (instructions)	7ms	8ms	10ms	11ms	0ms	3.4s
synthetic (title)	67ms	70ms	117ms	385ms	2359ms	15.9s
synthetic (string inside object)	62ms	65ms	74ms	199ms	1872ms	10.4s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	57ms	62ms	104ms	206ms	1405ms	13.6s
article (body)	18ms	20ms	23ms	225ms	344ms	5.9s
article (string inside object)	54ms	60ms	69ms	308ms	1250ms	9.4s
article (string inside array)	69ms	74ms	97ms	205ms	1855ms	10.3s
recipe (name)	34ms	35ms	39ms	86ms	86ms	9.3s
recipe (description)	30ms	33ms	42ms	103ms	37ms	6.7s
recipe (instructions)	7ms	10ms	11ms	45ms	0ms	3.4s
synthetic (title)	65ms	70ms	78ms	440ms	2407ms	15.3s
synthetic (string inside object)	63ms	69ms	75ms	407ms	2437ms	10.8s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

ryanbonial · 2024-10-03T20:00:35Z

@binoy14 The test pass, but I am seeing the addition of about 35 warnings about Warning: An update to ... inside a test was not wrapped in act(...). warnings.

binoy14 · 2024-10-04T14:20:45Z

@binoy14 The test pass, but I am seeing the addition of about 35 warnings about Warning: An update to ... inside a test was not wrapped in act(...). warnings.

Pretty sure they existed during jest as well but were getting swallowed by jest. Do you see any instances where it could be causing this?

My suggestion is if other changes looks good we merge this and do a follow up PR that fixes the warnings

ryanbonial

🚀 Sounds like a good plan for a follow-up PR that fixes the warnings

bjoerge · 2024-10-14T13:01:22Z

I just rebased this against next and migrated a couple of new tests that came in while this was waiting to be merged.

bjoerge

Thanks for taking this over the finishing line, @binoy14! <3

packages/sanity/test/form/index.ts

RitaDias

This is great work thank you @binoy14 and @bjoerge you're legends ❤️ ✨

This was referenced Oct 3, 2024

test(sanity): migrate more packages to vitest #7573

Merged

chore(test): move @sanity/block-tools to vitest #7579

Merged

vercel bot deployed to Preview – page-building-studio October 3, 2024 17:34 View deployment

vercel bot deployed to Preview – performance-studio October 3, 2024 17:34 View deployment

vercel bot deployed to Preview – test-studio October 3, 2024 17:34 View deployment

vercel bot deployed to Preview – test-next-studio October 3, 2024 17:37 View deployment

vercel bot deployed to Preview – test-compiled-studio October 3, 2024 17:38 View deployment

binoy14 changed the title ~~chore(test): move jest config to @repo/test-config/jest~~ test(sanity): migrate sanity package to vitest Oct 3, 2024

binoy14 force-pushed the test-migrate-repo branch from a511081 to 1467824 Compare October 3, 2024 17:47

vercel bot deployed to Preview – page-building-studio October 3, 2024 17:48 View deployment

vercel bot deployed to Preview – performance-studio October 3, 2024 17:48 View deployment

vercel bot deployed to Preview – test-studio October 3, 2024 17:48 View deployment

vercel bot deployed to Preview – test-compiled-studio October 3, 2024 17:49 View deployment

vercel bot deployed to Preview – test-next-studio October 3, 2024 17:49 View deployment

binoy14 marked this pull request as ready for review October 3, 2024 17:56

binoy14 requested a review from a team as a code owner October 3, 2024 17:56

binoy14 requested review from ryanbonial and bjoerge and removed request for a team October 3, 2024 17:56

ricokahler force-pushed the next branch from f1f9c51 to 92de3d9 Compare October 4, 2024 20:16

ryanbonial previously approved these changes Oct 4, 2024

View reviewed changes

bjoerge added 2 commits October 14, 2024 14:44

test(sanity): migrate sanity package to vitest

2cc7ea0

test(sanity): migrate remaining tests to vitest

261d657

bjoerge dismissed ryanbonial’s stale review via 261d657 October 14, 2024 12:55

bjoerge force-pushed the test-migrate-repo branch from 1467824 to 261d657 Compare October 14, 2024 12:55

vercel bot deployed to Preview – performance-studio October 14, 2024 12:58 View deployment

vercel bot deployed to Preview – page-building-studio October 14, 2024 12:58 View deployment

vercel bot deployed to Preview – test-studio October 14, 2024 12:59 View deployment

bjoerge requested a review from RitaDias October 14, 2024 13:01

vercel bot deployed to Preview – test-next-studio October 14, 2024 13:03 View deployment

vercel bot deployed to Preview – test-compiled-studio October 14, 2024 13:06 View deployment

bjoerge previously approved these changes Oct 14, 2024

View reviewed changes

RitaDias reviewed Oct 14, 2024

View reviewed changes

packages/sanity/test/form/index.ts Outdated Show resolved Hide resolved

bjoerge dismissed their stale review via a9870a8 October 14, 2024 13:42

bjoerge requested a review from RitaDias October 14, 2024 13:43

fixup! test(sanity): migrate sanity package to vitest

0213851

bjoerge force-pushed the test-migrate-repo branch from a9870a8 to 0213851 Compare October 14, 2024 13:45

RitaDias approved these changes Oct 14, 2024

View reviewed changes

bjoerge added this pull request to the merge queue Oct 14, 2024

Merged via the queue into next with commit 6d23434 Oct 14, 2024
52 checks passed

bjoerge deleted the test-migrate-repo branch October 14, 2024 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(sanity): migrate sanity package to vitest #7578

test(sanity): migrate sanity package to vitest #7578

binoy14 commented Oct 3, 2024 •

edited

Loading

vercel bot commented Oct 3, 2024 •

edited

Loading

binoy14 commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

ryanbonial commented Oct 3, 2024

binoy14 commented Oct 4, 2024

ryanbonial left a comment

bjoerge commented Oct 14, 2024

bjoerge left a comment

RitaDias left a comment

test(sanity): migrate sanity package to vitest #7578

test(sanity): migrate sanity package to vitest #7578

Conversation

binoy14 commented Oct 3, 2024 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Oct 3, 2024 • edited Loading

binoy14 commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024 • edited Loading

github-actions bot commented Oct 3, 2024 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

ryanbonial commented Oct 3, 2024

binoy14 commented Oct 4, 2024

ryanbonial left a comment

Choose a reason for hiding this comment

bjoerge commented Oct 14, 2024

bjoerge left a comment

Choose a reason for hiding this comment

RitaDias left a comment

Choose a reason for hiding this comment

binoy14 commented Oct 3, 2024 •

edited

Loading

vercel bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading