chore(perf): allow sharding efps tests #7592

binoy14 · 2024-10-04T16:33:45Z

Description

Shards EFPS tests to make them run faster. Should save about ~10 mins

What to review

Comment result is correct and the tests pass

Testing

N/A

Notes for release

N/A

vercel · 2024-10-04T16:33:49Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 3:22pm
performance-studio	✅ Ready (Inspect)	Visit Preview		Oct 15, 2024 3:22pm
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 3:22pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 3:22pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 3:22pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 15, 2024 3:22pm

binoy14 · 2024-10-04T16:34:05Z

chore(perf): allow sharding efps tests #7592 👈
next

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @binoy14 and the rest of your teammates on Graphite

github-actions · 2024-10-04T16:34:34Z

No changes to documentation

socket-security · 2024-10-04T16:35:11Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	environment, filesystem	`+15`	622 kB	oss-bot

View full report↗︎

github-actions · 2024-10-04T16:39:40Z

Component Testing Report Updated Oct 15, 2024 3:24 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	45s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	9s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	30s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	38s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	17s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	10s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	44s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 41s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 17s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	9s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	26s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	35s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-04T16:43:14Z

⚡️ Editor Performance Report

Updated Tue, 15 Oct 2024 15:29:35 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	18.9 efps (53ms)	18.2 efps (55ms)	+2ms (+3.8%)	✅
article (body)	53.8 efps (19ms)	56.2 efps (18ms)	-1ms (-4.3%)	✅
article (string inside object)	19.2 efps (52ms)	19.6 efps (51ms)	-1ms (-1.9%)	✅
article (string inside array)	15.4 efps (65ms)	15.4 efps (65ms)	+0ms (-/-%)	✅
recipe (name)	27.8 efps (36ms)	30.8 efps (33ms)	-4ms (-9.7%)	✅
recipe (description)	32.3 efps (31ms)	32.3 efps (31ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (7ms)	+1ms (-/-%)	✅
synthetic (title)	14.9 efps (67ms)	14.9 efps (67ms)	+0ms (-/-%)	✅
synthetic (string inside object)	15.5 efps (65ms)	15.6 efps (64ms)	-1ms (-0.8%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	53ms	57ms	76ms	192ms	1006ms	14.1s
article (body)	19ms	21ms	31ms	204ms	231ms	6.0s
article (string inside object)	52ms	57ms	69ms	185ms	1014ms	8.9s
article (string inside array)	65ms	68ms	80ms	323ms	1749ms	9.9s
recipe (name)	36ms	38ms	49ms	67ms	149ms	9.4s
recipe (description)	31ms	34ms	45ms	62ms	75ms	6.7s
recipe (instructions)	6ms	9ms	10ms	38ms	0ms	3.4s
synthetic (title)	67ms	71ms	76ms	163ms	1833ms	15.2s
synthetic (string inside object)	65ms	66ms	72ms	369ms	1537ms	9.8s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	55ms	59ms	64ms	182ms	1037ms	14.8s
article (body)	18ms	24ms	40ms	159ms	294ms	6.2s
article (string inside object)	51ms	55ms	64ms	124ms	768ms	8.5s
article (string inside array)	65ms	70ms	76ms	233ms	1725ms	9.8s
recipe (name)	33ms	35ms	42ms	64ms	129ms	9.4s
recipe (description)	31ms	33ms	41ms	86ms	111ms	6.5s
recipe (instructions)	7ms	9ms	11ms	34ms	0ms	3.4s
synthetic (title)	67ms	71ms	76ms	366ms	2156ms	15.2s
synthetic (string inside object)	64ms	66ms	74ms	531ms	1603ms	10.3s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

ricokahler

i love the refactors too

The merge-base changed after approval.

vercel bot deployed to Preview – page-building-studio October 4, 2024 16:34 View deployment

vercel bot deployed to Preview – test-studio October 4, 2024 16:34 View deployment

vercel bot deployed to Preview – performance-studio October 4, 2024 16:34 View deployment

vercel bot deployed to Preview – test-next-studio October 4, 2024 16:36 View deployment

vercel bot deployed to Preview – test-compiled-studio October 4, 2024 16:37 View deployment

binoy14 marked this pull request as ready for review October 4, 2024 16:45

binoy14 requested a review from a team as a code owner October 4, 2024 16:45

binoy14 requested review from ryanbonial and ricokahler and removed request for a team October 4, 2024 16:45

ricokahler previously approved these changes Oct 4, 2024

View reviewed changes

ricokahler force-pushed the next branch from f1f9c51 to 92de3d9 Compare October 4, 2024 20:16

ricokahler requested a review from a team as a code owner October 4, 2024 20:16

binoy14 force-pushed the 10-04-chore_perf_allow_sharding_efps_tests branch from 3171640 to 3400753 Compare October 6, 2024 20:04

binoy14 requested a review from ricokahler October 6, 2024 20:04

vercel bot deployed to Preview – performance-studio October 6, 2024 20:04 View deployment

vercel bot deployed to Preview – page-building-studio October 6, 2024 20:04 View deployment

vercel bot deployed to Preview – test-studio October 6, 2024 20:04 View deployment

vercel bot deployed to Preview – test-next-studio October 6, 2024 20:06 View deployment

vercel bot deployed to Preview – test-compiled-studio October 6, 2024 20:08 View deployment

binoy14 added 2 commits October 15, 2024 11:17

chore(perf): allow sharding efps tests

5dd9195

chore(ci): shard efps tests

759cc64

binoy14 force-pushed the 10-04-chore_perf_allow_sharding_efps_tests branch from 3400753 to 759cc64 Compare October 15, 2024 15:18

vercel bot deployed to Preview – performance-studio October 15, 2024 15:19 View deployment

vercel bot deployed to Preview – page-building-studio October 15, 2024 15:19 View deployment

vercel bot deployed to Preview – test-studio October 15, 2024 15:19 View deployment

vercel bot deployed to Preview – test-next-studio October 15, 2024 15:21 View deployment

vercel bot deployed to Preview – test-compiled-studio October 15, 2024 15:22 View deployment

ryanbonial approved these changes Oct 15, 2024

View reviewed changes

binoy14 added this pull request to the merge queue Oct 15, 2024

Merged via the queue into next with commit de51413 Oct 15, 2024
67 checks passed

binoy14 deleted the 10-04-chore_perf_allow_sharding_efps_tests branch October 15, 2024 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(perf): allow sharding efps tests #7592

chore(perf): allow sharding efps tests #7592

binoy14 commented Oct 4, 2024 •

edited

Loading

vercel bot commented Oct 4, 2024 •

edited

Loading

binoy14 commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

socket-security bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

ricokahler left a comment

chore(perf): allow sharding efps tests #7592

chore(perf): allow sharding efps tests #7592

Conversation

binoy14 commented Oct 4, 2024 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Oct 4, 2024 • edited Loading

binoy14 commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

socket-security bot commented Oct 4, 2024 • edited Loading

github-actions bot commented Oct 4, 2024 • edited Loading

github-actions bot commented Oct 4, 2024 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

ricokahler left a comment

Choose a reason for hiding this comment

binoy14 commented Oct 4, 2024 •

edited

Loading

vercel bot commented Oct 4, 2024 •

edited

Loading

socket-security bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading