feat: releases detail screen facelift. #7616

pedrobonamin · 2024-10-14T17:31:26Z

Description

Adds sanity/ui and sanity/icons local packages to develop in corel until the new version are released.
Updates the release detail view to match closer with the final designs.

Some caveats:

~~The table doesn't have full width borders, we discussed this in slack. We can revisit it later~~
It's not possible to edit the title and the description as an "in place" action, there is a follow up ticket for that COREL-193
Is not possible to edit the release type and the estimated release date, also, follow up ticket for that COREL-197
-The table has been reorganized, it shows now only the columns we want but the sorting doesn't work for the type given the sorting was created thinking only on dates, so we need to add a new option for this. See

sanity/packages/sanity/src/core/releases/tool/components/Table/Table.tsx

Line 113 in 8f3e94f

// TODO: Update this tos support sorting not only by date but also by string

What to review

Does the changes makes sense?

Testing

I didn't have enough time to include new tests, this could be done as a follow up.

Notes for release

vercel · 2024-10-14T17:31:30Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 18, 2024 2:30pm
performance-studio	✅ Ready (Inspect)	Visit Preview		Oct 18, 2024 2:30pm
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 18, 2024 2:30pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 18, 2024 2:30pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 18, 2024 2:30pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 18, 2024 2:30pm

github-actions · 2024-10-17T14:18:54Z

No changes to documentation

github-actions · 2024-10-17T14:25:13Z

Component Testing Report Updated Oct 18, 2024 2:27 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 18s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	15s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	44s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	1m 1s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	30s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	16s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 17s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	2m 44s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 46s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	40s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	27s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	54s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-17T14:36:53Z

⚡️ Editor Performance Report

Updated Fri, 18 Oct 2024 14:38:02 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	18.3 efps (55ms)	13.2 efps (76ms)	+21ms (+38.5%)	🔴
article (body)	63.7 efps (16ms)	59.7 efps (17ms)	+1ms (+6.7%)	✅
article (string inside object)	19.2 efps (52ms)	14.1 efps (71ms)	+19ms (+36.5%)	🔴
article (string inside array)	15.2 efps (66ms)	11.6 efps (86ms)	+20ms (+30.3%)	🔴
recipe (name)	31.3 efps (32ms)	21.3 efps (47ms)	+15ms (+46.9%)	🔴
recipe (description)	35.7 efps (28ms)	22.7 efps (44ms)	+16ms (+57.1%)	🔴
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (6ms)	+0ms (-/-%)	✅
synthetic (title)	15.2 efps (66ms)	6.0 efps (166ms)	+100ms (+150.8%)	🔴
synthetic (string inside object)	15.6 efps (64ms)	6.3 efps (158ms)	+94ms (+146.1%)	🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	55ms	63ms	71ms	181ms	369ms	13.1s
article (body)	16ms	17ms	19ms	197ms	224ms	5.4s
article (string inside object)	52ms	56ms	69ms	232ms	209ms	8.6s
article (string inside array)	66ms	71ms	85ms	185ms	833ms	9.4s
recipe (name)	32ms	36ms	62ms	88ms	9ms	8.8s
recipe (description)	28ms	31ms	35ms	56ms	0ms	5.9s
recipe (instructions)	6ms	8ms	9ms	10ms	0ms	3.2s
synthetic (title)	66ms	70ms	78ms	581ms	1836ms	15.8s
synthetic (string inside object)	64ms	69ms	77ms	637ms	1602ms	10.0s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	76ms	81ms	93ms	267ms	2341ms	17.0s
article (body)	17ms	21ms	43ms	153ms	227ms	5.6s
article (string inside object)	71ms	75ms	85ms	250ms	2050ms	10.3s
article (string inside array)	86ms	90ms	99ms	328ms	2837ms	11.6s
recipe (name)	47ms	51ms	68ms	108ms	724ms	10.6s
recipe (description)	44ms	46ms	59ms	125ms	556ms	7.7s
recipe (instructions)	6ms	8ms	10ms	34ms	0ms	3.2s
synthetic (title)	166ms	176ms	289ms	1044ms	9865ms	26.3s
synthetic (string inside object)	158ms	169ms	186ms	670ms	8889ms	20.1s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

…nd `@sanity/icons` prereleases

juice49 force-pushed the corel-192 branch from 8f3e94f to 1ae631d Compare October 15, 2024 08:56

vercel bot had a problem deploying to Preview – page-building-studio October 15, 2024 08:59 Failure

vercel bot had a problem deploying to Preview – performance-studio October 15, 2024 08:59 Failure

vercel bot had a problem deploying to Preview – test-studio October 15, 2024 08:59 Failure

vercel bot had a problem deploying to Preview – test-compiled-studio October 15, 2024 08:59 Failure

vercel bot had a problem deploying to Preview – test-next-studio October 15, 2024 08:59 Failure

bjoerge force-pushed the corel branch from f32a593 to 98775b4 Compare October 16, 2024 08:24

vercel bot had a problem deploying to Preview – performance-studio October 16, 2024 10:28 Failure

vercel bot had a problem deploying to Preview – page-building-studio October 16, 2024 10:28 Failure

vercel bot had a problem deploying to Preview – test-studio October 16, 2024 10:28 Failure

vercel bot had a problem deploying to Preview – test-next-studio October 16, 2024 10:28 Failure

vercel bot had a problem deploying to Preview – test-compiled-studio October 16, 2024 10:28 Failure

juice49 force-pushed the corel-192 branch from fbe84f1 to 352c845 Compare October 17, 2024 13:57

vercel bot had a problem deploying to Preview – page-building-studio October 17, 2024 13:59 Failure

vercel bot had a problem deploying to Preview – test-studio October 17, 2024 13:59 Failure

vercel bot had a problem deploying to Preview – performance-studio October 17, 2024 13:59 Failure

vercel bot had a problem deploying to Preview – test-next-studio October 17, 2024 13:59 Failure

vercel bot had a problem deploying to Preview – test-compiled-studio October 17, 2024 14:00 Failure

vercel bot deployed to Preview – performance-studio October 17, 2024 14:19 View deployment

vercel bot deployed to Preview – page-building-studio October 17, 2024 14:19 View deployment

vercel bot deployed to Preview – test-studio October 17, 2024 14:19 View deployment

vercel bot deployed to Preview – test-next-studio October 17, 2024 14:24 View deployment

vercel bot deployed to Preview – test-compiled-studio October 17, 2024 14:27 View deployment

pedrobonamin added 3 commits October 18, 2024 15:17

chore(corel): remove delete bundle action from releasesMenuButton

3cf06e7

fix(core): add sanity/ui and sanity/icons local packages

cc09017

feat(corel): update releases detail screen

fc11284

juice49 added 3 commits October 18, 2024 15:17

feat(sanity): enable full-bleed tables

16d6e2e

fix(sanity): use new release type strings

5e8f03f

chore(sanity): #TEMPORARY expect TS errors while using @sanity/ui a…

030d67d

…nd `@sanity/icons` prereleases

juice49 force-pushed the corel-192 branch from 4d10ae6 to 030d67d Compare October 18, 2024 14:17

juice49 marked this pull request as ready for review October 18, 2024 14:17

juice49 requested a review from a team as a code owner October 18, 2024 14:17

juice49 requested review from ricokahler and removed request for a team October 18, 2024 14:17

juice49 merged commit 3fb444f into corel Oct 18, 2024
33 of 41 checks passed

juice49 deleted the corel-192 branch October 18, 2024 14:17

vercel bot deployed to Preview – performance-studio October 18, 2024 14:21 View deployment

vercel bot deployed to Preview – page-building-studio October 18, 2024 14:21 View deployment

vercel bot deployed to Preview – test-studio October 18, 2024 14:22 View deployment

vercel bot deployed to Preview – test-next-studio October 18, 2024 14:26 View deployment

vercel bot deployed to Preview – test-compiled-studio October 18, 2024 14:30 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: releases detail screen facelift. #7616

feat: releases detail screen facelift. #7616

pedrobonamin commented Oct 14, 2024 •

edited by juice49

Loading

vercel bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

feat: releases detail screen facelift. #7616

feat: releases detail screen facelift. #7616

Conversation

pedrobonamin commented Oct 14, 2024 • edited by juice49 Loading

Description

What to review

Testing

Notes for release

vercel bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

pedrobonamin commented Oct 14, 2024 •

edited by juice49

Loading

vercel bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading