Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corel local packages #7618

Draft
wants to merge 2 commits into
base: corel
Choose a base branch
from
Draft

Corel local packages #7618

wants to merge 2 commits into from

Conversation

pedrobonamin
Copy link
Contributor

Description

Note

This won't make it to next is just to develop corel until the packages are updated in it's place

Adds sanity/ui and sanity/icons local packages to develop in corel until the new version are released.
Updates StatusButton and ImagePreviewStyled to have fallback values for not supported colors in deprecated sanity/ui theme v1.

What to review

Is it correct to include the new packages like this?

Testing

Existing tests should cover this change.

Notes for release

n/a

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:06am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:06am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:06am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:06am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:06am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 9:06am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Component Testing Report Updated Oct 15, 2024 9:02 AM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 17s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 38s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 45s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 41s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 4s 11 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 15, 2024

⚡️ Editor Performance Report

Updated Tue, 15 Oct 2024 09:15:35 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 18.2 efps (55ms) 11.9 efps (84ms) +29ms (+52.7%) 🔴
article (body) 52.1 efps (19ms) 53.5 efps (19ms) -1ms (-2.6%)
article (string inside object) 18.2 efps (55ms) 13.0 efps (77ms) +22ms (+40.0%) 🔴
article (string inside array) 14.7 efps (68ms) 10.8 efps (93ms) +25ms (+36.8%) 🔴
recipe (name) 29.4 efps (34ms) 20.2 efps (50ms) +16ms (+45.6%) 🔴
recipe (description) 33.3 efps (30ms) 21.3 efps (47ms) +17ms (+56.7%) 🔴
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (6ms) -1ms (-/-%)
synthetic (title) 14.9 efps (67ms) 5.9 efps (170ms) +103ms (+153.0%) 🔴
synthetic (string inside object) 15.9 efps (63ms) 6.1 efps (163ms) +100ms (+158.7%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 55ms 61ms 95ms 196ms 1065ms 14.4s
article (body) 19ms 22ms 63ms 207ms 486ms 6.3s
article (string inside object) 55ms 59ms 72ms 238ms 1360ms 9.3s
article (string inside array) 68ms 71ms 80ms 204ms 1930ms 10.2s
recipe (name) 34ms 37ms 44ms 66ms 78ms 9.3s
recipe (description) 30ms 34ms 37ms 97ms 79ms 6.5s
recipe (instructions) 7ms 8ms 10ms 24ms 0ms 3.4s
synthetic (title) 67ms 69ms 77ms 355ms 2304ms 17.3s
synthetic (string inside object) 63ms 67ms 73ms 627ms 2574ms 10.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 84ms 88ms 111ms 303ms 2706ms 17.0s
article (body) 19ms 23ms 57ms 238ms 436ms 6.4s
article (string inside object) 77ms 83ms 116ms 213ms 2477ms 11.5s
article (string inside array) 93ms 100ms 113ms 272ms 3408ms 12.4s
recipe (name) 50ms 52ms 79ms 125ms 849ms 11.9s
recipe (description) 47ms 48ms 58ms 76ms 625ms 7.8s
recipe (instructions) 6ms 8ms 9ms 11ms 18ms 3.5s
synthetic (title) 170ms 179ms 203ms 709ms 10193ms 29.2s
synthetic (string inside object) 163ms 171ms 187ms 747ms 9325ms 20.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant