-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preview link sharing with QR code #1994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stipsan
force-pushed
the
add-qr-code-preview-sharing
branch
from
October 21, 2024 13:17
5794cf8
to
8b9ee15
Compare
rdunk
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is very cool.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing Preview Sharing ✨
preview.sharing.mov
Preview Sharing creates share links with codes that are valid for as long as you want them to be. Toggling sharing off/on will create a new code that makes previous URLs no longer valid.
It also shows a QR code to enable quickly opening a PR on your phone to test your content in context before publishing it.
Prerequisites
For the menu to show up you'll need to have preview mode configured:
And to use
@sanity/preview-kit
v2 in your app for callingvalidatePreviewUrl
in your API route, v1 doesn't support the new custom-duration preview URL secrets used to authenticate the request to see draft content.Permissions
By default only Editor's or above can toggle sharing, although Enterprise plans with custom roles can change this.
Opting out
The menu is enabled by default when
previewMode.enable
is setup. You can turn it off by settingshareAccess
tofalse
.