Catch up with upstream changes #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a header only intended to support for Web Origin security in browsers. Other clients are not required to include this header, and the current case complicates servers since it receiving 'ws://' or 'ws://' in the 'Origin' header is highly unusual. RFC 6455, Section 4.1, Client Requirements: > Additionally, if the client is a web browser, it supplies /origin/. RFC 6455, Section 4.2.1, Reading the Client's Opening Handshake: > Optionally, an |Origin| header field. This header field is sent by > all browser clients. A connection attempt lacking this header field > SHOULD NOT be interpreted as coming from a browser client.
Do not send 'Origin' header in handshake
Fixed start_link spec to include binary option on URL
very minor, init accepts binary strings
More accurate type spec for websocket_terminate, other minor cleanup
…normal code on error
websocket_terminate type overhaul
|
Hey @sanmiguel @jeremyong 👋 Thanks for keeping this alive! Maybe you folks can consider creating an organisation and putting your efforts together? I honestly just want to write a client for SurrealDB and face a necessity to reinvent the wheel that would be times worse compared to the client that many people already collaborated on. That sucks! So, I hope there is a chance we can have a good tool and keep building on top of it ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.