Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: address some golangci-lint findings #126

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

scop
Copy link

@scop scop commented Aug 18, 2023

Address some findings from golangci-lint, using its defaults.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (bbc9f89) 89.21% compared to head (98d02cd) 89.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   89.21%   89.21%   -0.01%     
==========================================
  Files          10       10              
  Lines        2652     2651       -1     
==========================================
- Hits         2366     2365       -1     
  Misses        237      237              
  Partials       49       49              
Files Changed Coverage Δ
compiler.go 89.43% <100.00%> (-0.02%) ⬇️
format.go 96.77% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santhosh-tekuri santhosh-tekuri merged commit ce3bd6e into santhosh-tekuri:master Aug 21, 2023
3 checks passed
@scop scop deleted the style/lint branch August 21, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants