feat(notifications): added notifications #176
Open
+179
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serafim-san
changed the title
serafim-san
force-pushed
the
feat/notifications-implementation-using-svelte-5-san-webkit-next
branch
from
4c80464
to
ab69324
Compare
serafim-san
changed the title
serafim-san
commented
Sep 12, 2024
| @@ -1,6 +1,6 @@ | |||
| import { Query } from '$lib/api/executor.js' | |||
| import { useStripeCtx } from '$lib/ctx/stripe/index.js' | |||
| import { notifcation } from '$ui/core/Notifications/index.js' | |||
| import { notification } from '$ui/core/Notifications/index.js' | |||
There was a problem hiding this comment.
fixed typo in notification object
serafim-san
force-pushed
the
feat/notifications-implementation-using-svelte-5-san-webkit-next
branch
3 times, most recently
from
e2c1e6f
to
a9c708f
Compare
serafim-san
force-pushed
the
feat/notifications-implementation-using-svelte-5-san-webkit-next
branch
2 times, most recently
from
8b83c53
to
4a5fd47
Compare
serafim-san
force-pushed
the
feat/notifications-implementation-using-svelte-5-san-webkit-next
branch
from
4a5fd47
to
0282bf0
Compare
serafim-san
commented
Sep 12, 2024
| message: string, | ||
| options?: Omit<ComponentProps<Component>, 'icon' | 'message'>, | ||
| ) { | ||
| return toast.custom(Component as unknown as ComponentType, { |
There was a problem hiding this comment.
I had to do this because of the different types of components in Svelte 4 and Svelte 5
There was a problem hiding this comment.
Error I encountered when trying to pass a component without type conversion:
Argument of type '__sveltets_2_IsomorphicComponent<Props, { closeToast: CustomEvent<any>; } & { [evt: string]: CustomEvent<any>; }, {}, {}, "">' is not assignable to parameter of type 'ComponentType'.
Type '__sveltets_2_IsomorphicComponent<Props, { closeToast: CustomEvent<any>; } & { [evt: string]: CustomEvent<any>; }, {}, {}, "">' is not assignable to type 'new (options: ComponentConstructorOptions<Record<string, any>>) => SvelteComponent<Record<string, any>, any, any>'.
Types of parameters 'options' and 'options' are incompatible.
Type 'ComponentConstructorOptions<Record<string, any>>' is not assignable to type 'ComponentConstructorOptions<Props>'.
Type 'Record<string, any>' is missing the following properties from type 'Props': icon, messagets(2345)
serafim-san
commented
Sep 12, 2024
src/lib/ui/core/Dialog/vaul.ts
Outdated
| export const getVaulCtx = (ctx = getAllContexts()): [] | [Symbol, any] => | ||
| Array.from(ctx.entries()).find(([key, value]) => value?.states?.drawerId) || [] | ||
| export const getVaulCtx = (ctx = getAllContexts()): [] | [symbol, any] => | ||
| Array.from(ctx.entries()).find(([_key, value]) => value?.states?.drawerId) || [] |
There was a problem hiding this comment.
It was changed because eslint error. Symbol letter case changed automatically by eslint --fix
serafim-san
commented
Sep 12, 2024
| @@ -1 +1 @@ | |||
| export { default } from './InsightCard.svelte'; | |||
| export { default } from './InsightCard.svelte' | |||
There was a problem hiding this comment.
It was hanged automatically by eslint --fix
serafim-san
force-pushed
the
feat/notifications-implementation-using-svelte-5-san-webkit-next
branch
from
e6ece4b
to
7beab05
Compare
serafim-san
force-pushed
the
feat/notifications-implementation-using-svelte-5-san-webkit-next
branch
from
7beab05
to
db8dcf3
Compare
…te-5-san-webkit-next
…te-5-san-webkit-next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added notifications
Notion card
New design
Old one
Screenshots