Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment to new issuer #9

Open
auhlig opened this issue Jan 19, 2024 · 2 comments
Open

Adjustment to new issuer #9

auhlig opened this issue Jan 19, 2024 · 2 comments
Assignees

Comments

@auhlig
Copy link
Member

auhlig commented Jan 19, 2024

The interface for an external issuer to the cert-manager changed.
Previously, it was required to specify the group, version and kind (unless defaulted) for certificates. This is no longer the case. Furthermore, custom kinds are not allowed.
We need to adjust our CRDs to be of kind issuer and/or clusterIssuer and the corresponding implementation in the controller.
Without specifying the full issuer reference (group, version, kind) in a cert-manager certificate various failures might occur.
Thus, the issuer is no longer productively usable with the latest cert-manager as we use kind: DigicertIssuer. See here.

Also the approval conditions should be supported.
Bonus points: Request to be added to the list of issuers to increase visibility.

@auhlig
Copy link
Member Author

auhlig commented Jan 24, 2024

Reworking to adjust to the newer external issuer interface is quite an effort.
We're currently looking into a pragamatic alternatives such as ACME-based issuers for DigiCert and ultimately deprecating this project.

@auhlig
Copy link
Member Author

auhlig commented Feb 3, 2024

@kayrus took on the task of trying the ACME solution.
Unfortunately, it's not a viable solution at the moment and we need to stick with the digicert-issuer.
Support for recent cert-managers was added via #10 and is part of release v2.2.0.

Further cleanup might be necessary but is currently not a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant