Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certificaterequest controller group test #11

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jknipper
Copy link
Contributor

cert-manager is creating certificaterequests without a group set in issuerRef for self-signed certificates and digicert-issuer is messing up those requests.
cc @auhlig @kayrus

@jknipper
Copy link
Contributor Author

I guess this is also related to #9

@kayrus
Copy link
Contributor

kayrus commented Aug 28, 2024

Please hold on with this. There was a reason why we haven't modified this earlier (see #8). I just need some time to remember why.
Also, why haven't we faced this problem earlier?

@jknipper
Copy link
Contributor Author

Using self-signed certificates is a newer use case I guess. And maybe also the group got removed from issuerRef in recent versions because there is only the cert-manager one?

@kayrus
Copy link
Contributor

kayrus commented Aug 28, 2024

@jknipper I'm confused. What is a connection between self-signed certs and digicert signed certs?

@jknipper
Copy link
Contributor Author

The digicert-issuer is mangling statuses of the certificate requests for self-signed certs and breaks them. I think this is just a bug and shouldn't affect the digicert stuff.

@Nuckal777
Copy link

Nuckal777 commented Aug 28, 2024

Also, why haven't we faced this problem earlier?

At least I've encountered the issue weeks ago already, but learned about looking CertificateRequests only this week.

Copy link
Contributor

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's give it a try and test in qa env. fingers crossed that this won't cause any issues.

@jknipper jknipper merged commit 10c69f5 into master Sep 3, 2024
1 check passed
@jknipper jknipper deleted the fix_certificaterequest_controller branch September 3, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants