Close opened connections (#43)

sapcc · Aug 2, 2022 · 2c653d8 · 2c653d8
1 parent 335a08c
commit 2c653d8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/database/maria_util.go b/pkg/database/maria_util.go
@@ -77,6 +77,8 @@ func purgeBinlogsBefore(c config.DatabaseConfig, minutes int) (err error) {
 		return
 	}
 
+	defer conn.Close()
+
 	if err = conn.Ping(); err != nil {
 		return
 	}
@@ -110,6 +112,8 @@ func purgeBinlogsTo(c config.DatabaseConfig, log string) (err error) {
 		return
 	}
 
+	defer conn.Close()
+
 	if err = conn.Ping(); err != nil {
 		return
 	}
@@ -127,6 +131,8 @@ func resetSlave(c config.DatabaseConfig) (err error) {
 		return fmt.Errorf("connection for slave reset failed: %s", err.Error())
 	}
 
+	defer conn.Close()
+
 	if err = conn.Ping(); err != nil {
 		return
 	}

diff --git a/pkg/database/mariadb.go b/pkg/database/mariadb.go
@@ -160,11 +160,13 @@ func (m *MariaDB) GetCheckSumForTable(verifyTables []string, withIP bool) (cs Ch
 	if err != nil {
 		return
 	}
+
+	defer conn.Close()
+
 	if err = conn.Ping(); err != nil {
 		return
 	}
 
-	defer conn.Close()
 	m.FlushIncBackup()
 	rs, err := conn.Execute(fmt.Sprintf("CHECKSUM TABLE %s", strings.Join(verifyTables, ", ")))
 	if err != nil {