lint

accelsim_tracing/benchmark/builder.go

@@ -2,7 +2,7 @@ package benchmark
 
 import (
 	"github.com/sarchlab/mgpusim/v3/accelsim_tracing/nvidia"
-	tracereader "github.com/sarchlab/mgpusim/v3/accelsim_tracing/traceReader"
+	"github.com/sarchlab/mgpusim/v3/accelsim_tracing/tracereader"
 )
 
 type BenchmarkBuilder struct {

accelsim_tracing/benchmark/doc.go

@@ -1,2 +1,2 @@
-// The benchmark package can load trace information and run simulation.
+// Package benchmark can load trace information and run simulation.
 package benchmark

accelsim_tracing/driver/doc.go

@@ -1,2 +1,2 @@
-// The driver package provides driver component which arrange kernels for devices.
+// Package driver provides driver component which arrange kernels for devices.
 package driver

accelsim_tracing/gpu/doc.go

@@ -1,2 +1,2 @@
-// The gpu package implements the gpu ticking component .
+// Package gpu implements the gpu ticking component .
 package gpu

accelsim_tracing/message/doc.go

@@ -1,2 +1,2 @@
-// The message package contains the types for all the sim.msgs.
+// Package message contains the types for all the sim.msgs.
 package message

accelsim_tracing/nvidia/doc.go

@@ -1,2 +1,2 @@
-// The nvidia package contains some basic types.
+// Package nvidia contains some basic types.
 package nvidia

accelsim_tracing/platform/A100builder.go

@@ -42,8 +42,8 @@ func (b *A100PlatformBuilder) Build() *Platform {
 	return p
 }
 
-func (p *A100PlatformBuilder) freqMustBeSet() {
-	if p.freq == 0 {
+func (b *A100PlatformBuilder) freqMustBeSet() {
+	if b.freq == 0 {
 		panic("Frequency must be set")
 	}
 }

accelsim_tracing/platform/doc.go

@@ -1,3 +1,3 @@
-// The platform package organizes all the components needed for a simulation.
+// Package platform organizes all the components needed for a simulation.
 // Including the driver, the GPU, and the simulation engine.
 package platform

accelsim_tracing/runner/doc.go

@@ -1,3 +1,3 @@
-// The runner package provides the main entry point for the simulation.
+// Package runner provides the main entry point for the simulation.
 // It contains platform and benchmarks.
 package runner

accelsim_tracing/sm/doc.go

@@ -1,2 +1,2 @@
-// The sm package implements the SM ticking component.
+// Package sm implements the SM ticking component.
 package sm

accelsim_tracing/subcore/subcore.go

@@ -34,8 +34,6 @@ func (s *Subcore) Tick(now sim.VTimeInSec) bool {
 	madeProgress = s.processSMInput(now) || madeProgress
 	// warps can be switched, but ignore now
 
-	// fmt.Println("Subcore tick, time is:", now, "madeProgress:", madeProgress, "unfinishedInstsCount:", s.unfinishedInstsCount, "finishedWarpsCount:", s.finishedWarpsCount)
-
 	return madeProgress
 }
 

accelsim_tracing/tracereader/doc.go

@@ -0,0 +1,2 @@
+// Package tracereader provides reader that load benchmarks from trace flie
+package tracereader

accelsim_tracing/traceReader/reader_test.go → accelsim_tracing/tracereader/reader_test.go

@@ -5,7 +5,7 @@ import (
 	"testing"
 
 	"github.com/sarchlab/mgpusim/v3/accelsim_tracing/nvidia"
-	tracereader "github.com/sarchlab/mgpusim/v3/accelsim_tracing/traceReader"
+	"github.com/sarchlab/mgpusim/v3/accelsim_tracing/tracereader"
 )
 
 func TestBuildExecFromText(t *testing.T) {