This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
WIP: Make Sardana storage Tango independent #1495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check requirements is a task of the packaging tool and a question of properly specified dependencies. Disable it.
These imports prevents storage module to be used without PyTango. PyTango is unnecessarily imported. Remove it together with other unnecessary imports.
This AbortException class is used just in one place - when creation of the Tango server is aborted (added recently). This class will be substituted by the AbortedException class from the msexception module which is a real SardanaException.
Interrupt exceptions are generic enough to be considered as base sardana exceptions. Move them from the taurus extensions module.
Delay PyTango imports so the storage modules could be used without PyTango.
The purpose of these classes is unknown. Since they are not used and clearly marked as a temporary implementation move them to the test directory (just in case we need them in the future).
Delay PyTango import in FIO recorder so the rest of the recorders could be used even if PyTango is not installed.
Delay Type import, which at the end results in PyTango import, in FIO recorder so the rest of the recorders could be used even if PyTango is not installed.
Delay Taurus-Tango import in gscan module in order to allow storage classes imports.
# Conflicts: # src/sardana/__init__.py # src/sardana/macroserver/msexception.py # src/sardana/macroserver/recorders/storage.py # src/sardana/macroserver/scan/gscan.py # src/sardana/taurus/core/tango/sardana/pool.py # src/sardana/taurus/core/tango/sardana/sardana.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sardana storage part should in principle be Tango independent. When few years ago our sys admins asked us to provide a minimum code (without the need to install Tango) that would execute a Sardana scan then we learned that it is not.
At that time I made some effort to make the:
sardana.macroserver.recorders.storagesardana.macroserver.scanimportable without installing Tango.
Here I post this work, after just updating it with the develop branch (it was developed when Sardana was still python 2).
There are still two pending points:
sardana.taurus.core.tango.sardana.pool.Readydoes not rely on Tango state enumerationtaurus.core.tango.tangovalidator.TangoDeviceNameValidatorwithout Tango being installed.The project that simulates a minimum scan from the point of view of data storage is placed here: https://github.com/reszelaz/storage-kpi and I just checked it again and it works without installing Tango.