This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
fix: lsmeas use name instead of channel label #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a element is renamed using renameelem the macro lsmeas still shows the previous name (label) sardana-org#1053. We propose to adquire and show the name of the elements of the measurement group from the full name (i.e: ct1, ct2, sys/tg_test/1/ampli). closes sardana-org#1053.
|
the call |
|
Yes, but it's a deprecated method and with @reszelaz we decided that probably the best we can do is remove the timer column from the macro. So it shouldn't be a problem for now. I will make another pull request removing the timer column as soon as this one gets accepted. |
13bscsaamjad
approved these changes
Jul 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an element is renamed using renameelem the macro lsmeas still shows the previous name (label) #1053.
We propose to acquire and show the name of the elements of the measurement group from the full name (i.e: ct1, ct2, sys/tg_test/1/ampli).
closes #1053.