rename events & run in hook functions #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional callback when a task transitions to an error state and aligns the existing callbacks with task states. It also moves execution into the hook functions where applicable.
entereted_eventwas renamed toupdate_event,finished_eventwas changed torun_eventandreached_eventwas removed`. The current set of callbacks areupdate_event(emitted in_update_hook)ready_event(emitted in_on_ready_hook)completed_event(emitted in_on_complete_hookon successful completion)error_event(emitted in_on_error_hookon unsuccessful completion)run_event(emitted in_run_hookwhenever a task is run regardless of result)cancelled_event(called in_on_cancel)