Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul pythonfinder #135

Merged
merged 27 commits into from
May 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5ef4c59
Overhaul pythonfinder to use pydantic and eliminate the WindowsFinder…
matteius Apr 29, 2023
e54d043
add missing file
matteius Apr 29, 2023
f4b7ee7
Corrected imports
matteius Apr 29, 2023
11fcf43
addressing build error
matteius Apr 29, 2023
011575f
address import issue with tests
matteius Apr 29, 2023
c5eb2f6
address import issue with tests
matteius Apr 29, 2023
095c972
Merge branch 'master' into overhaul-to-pydantic
matteius Apr 29, 2023
784839c
Try casting to Path in test
matteius Apr 29, 2023
62ea0b7
Merge branch 'overhaul-to-pydantic' of github.com:sarugaku/pythonfind…
matteius Apr 29, 2023
7e30a14
Try casting to PythonFinder in test
matteius Apr 29, 2023
86f1550
Try casting to PythonFinder in test
matteius Apr 29, 2023
93145f8
Try casting to PythonFinder in test
matteius Apr 29, 2023
270738f
Try casting to PythonFinder in test
matteius Apr 29, 2023
e54050e
remove not necceessary validator that may be causing test failures.
matteius Apr 29, 2023
b375139
Refactor imports based on pydantic bug report.
matteius Apr 29, 2023
1fa5706
apply simiilar fix to this test
matteius Apr 29, 2023
2a60b74
remove nonexistent method.
matteius Apr 29, 2023
db37936
Remove unused class
matteius Apr 29, 2023
7d1872f
iterate on last two tests
matteius Apr 29, 2023
c86624e
factor tests away from importlib
matteius Apr 29, 2023
3621712
Assertion was checking that it mocked itself.
matteius Apr 29, 2023
7292280
Assertion was checking that it mocked itself.
matteius Apr 29, 2023
0220167
Assertion was checking that it mocked itself.
matteius Apr 29, 2023
8feed67
Remove confusing and bad test cases
matteius Apr 29, 2023
fb3c727
PR feedback
matteius Apr 30, 2023
ff866d3
PR feedback
matteius Apr 30, 2023
6598298
PR feedback
matteius Apr 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ package_data =
LICENSE*
README*
install_requires =
attrs
cached-property
packaging>=22.0
pydantic>=1.10.7

[options.packages.find]
where = src
Expand Down Expand Up @@ -113,7 +113,7 @@ skip = src/pythonfinder/_vendor
line_length = 90
indent = ' '
multi_line_output = 3
known_third_party = attr,cached_property,click,invoke,packaging,parver,pytest,requests,setuptools,six,towncrier
known_third_party = cached_property,click,invoke,packaging,parver,pydantic,pytest,requests,setuptools,six,towncrier
known_first_party = pythonfinder,tests
combine_as_imports=True
include_trailing_comma = True
Expand Down
15 changes: 2 additions & 13 deletions src/pythonfinder/__init__.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,8 @@
# Add NullHandler to "pythonfinder" logger, because Python2's default root
# logger has no handler and warnings like this would be reported:
#
# > No handlers could be found for logger "pythonfinder.models.pyenv"
from __future__ import annotations

import logging

from .exceptions import InvalidPythonVersion
from .models import SystemPath, WindowsFinder
from .models import SystemPath
from .pythonfinder import Finder

__version__ = "1.3.3.dev0"


logger = logging.getLogger(__name__)
logger.addHandler(logging.NullHandler())

__all__ = ["Finder", "WindowsFinder", "SystemPath", "InvalidPythonVersion"]
__all__ = ["Finder", "SystemPath", "InvalidPythonVersion"]
21 changes: 0 additions & 21 deletions src/pythonfinder/_vendor/pep514tools/LICENSE

This file was deleted.

11 changes: 0 additions & 11 deletions src/pythonfinder/_vendor/pep514tools/__init__.py

This file was deleted.

7 changes: 0 additions & 7 deletions src/pythonfinder/_vendor/pep514tools/__main__.py

This file was deleted.

198 changes: 0 additions & 198 deletions src/pythonfinder/_vendor/pep514tools/_registry.py

This file was deleted.

Loading