Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip out unnecessary dependencies #81

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Strip out unnecessary dependencies #81

merged 2 commits into from
Mar 4, 2020

Conversation

techalchemy
Copy link
Member

  • Remove vistir and crayons
  • Reimplement heavily relied-upon functionality
  • Copy over vistir utilities used heavily in tests to avoid this as a
    test dependency as well
  • Rewrite mocks that relied on vistir-specific invocations
  • Regenerate lockfile
  • Begins to address Reduce/Eliminate dependencies #78

Signed-off-by: Dan Ryan [email protected]

- Remove `vistir` and `crayons`
- Reimplement heavily relied-upon functionality
- Copy over `vistir` utilities used heavily in tests to avoid this as a
  test dependency as well
- Rewrite mocks that relied on vistir-specific invocations
- Regenerate lockfile
- Begins to address #78

Signed-off-by: Dan Ryan <[email protected]>
@ghost
Copy link

ghost commented Jan 7, 2020

DeepCode's analysis on #62c39f found:

  • 0 critical issues. ⚠️ 0 warnings and 8 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@techalchemy
Copy link
Member Author

Note that attrs forms the backbone of all of the classes used in the library, cached-property drives the performance gains i've managed to sneak out of it, and while packaging is largely used for type hints it's not a huge price to pay

Signed-off-by: Dan Ryan <[email protected]>
@techalchemy techalchemy merged commit 5285614 into master Mar 4, 2020
@pradyunsg pradyunsg deleted the feature/78 branch March 4, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant