fix(discord): fix extra newlines, close koishijs/koishi#1247

satorijs · Nov 4, 2023 · 7d2e604 · 7d2e604
1 parent 4753780
commit 7d2e604
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/adapters/discord/package.json b/adapters/discord/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@satorijs/adapter-discord",
   "description": "Discord Adapter for Satorijs",
-  "version": "4.1.3",
+  "version": "4.1.4",
   "main": "lib/index.js",
   "typings": "lib/index.d.ts",
   "files": [

diff --git a/adapters/discord/src/message.ts b/adapters/discord/src/message.ts
@@ -251,7 +251,6 @@ export class DiscordMessageEncoder<C extends Context = Context> extends MessageE
       if (!this.buffer.endsWith('\n')) this.buffer += '\n'
       await this.render(children)
       if (!this.buffer.endsWith('\n')) this.buffer += '\n'
-      this.buffer += '\n'
     } else if (type === 'blockquote') {
       if (!this.buffer.endsWith('\n')) this.buffer += '\n'
       this.buffer += '> '

diff --git a/adapters/zulip/package.json b/adapters/zulip/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@satorijs/adapter-zulip",
   "description": "Zulip Adapter for Satorijs",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "main": "lib/index.js",
   "typings": "lib/index.d.ts",
   "files": [

diff --git a/adapters/zulip/src/message.ts b/adapters/zulip/src/message.ts
@@ -66,9 +66,9 @@ export class ZulipMessageEncoder<C extends Context = Context> extends MessageEnc
     if (type === 'text') {
       this.buffer += escape(attrs.content)
     } else if (type === 'p') {
-      this.buffer += '\n'
+      if (!this.buffer.endsWith('\n')) this.buffer += '\n'
       await this.render(children)
-      this.buffer += '\n'
+      if (!this.buffer.endsWith('\n')) this.buffer += '\n'
     } else if (type === 'b' || type === 'strong') {
       this.buffer += ` **`
       await this.render(children)