Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qq): remove timestamp in type Request #208

Merged

Conversation

ilharp
Copy link
Contributor

@ilharp ilharp commented Dec 20, 2023

No description provided.

@ilharp
Copy link
Contributor Author

ilharp commented Dec 20, 2023

timestamp: Math.floor(Date.now() / 1000),

这里为什么会有一个 timestamp,搜索了文档,没有提到需要传 timestamp

Copy link
Contributor

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删了类型不考虑同时把实现传进去的删掉吗?

@shigma
Copy link
Contributor

shigma commented Dec 20, 2023

cc @XxLittleCxX

@XxLittleCxX
Copy link
Member

旧版文档有说发群消息要 timestamp,刚试了下不传也能发,你把实现也删一下吧

@ilharp
Copy link
Contributor Author

ilharp commented Dec 21, 2023

eb7c440

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f302796) 86.08% compared to head (eb7c440) 86.08%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   86.08%   86.08%           
=======================================
  Files           1        1           
  Lines         503      503           
  Branches      111      111           
=======================================
  Hits          433      433           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shigma shigma merged commit aaea140 into satorijs:master Dec 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants