Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add govulncheck-action #600

Merged
merged 3 commits into from
Dec 14, 2023
Merged

ci: add govulncheck-action #600

merged 3 commits into from
Dec 14, 2023

Conversation

mmatczuk
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Dec 14, 2023

PR Summary

  • Establishment of End-to-End Testing Workflow
    A new workflow has been set up devoted to performing end-to-end testing. This is an important step as it tests our system from start to finish, ensuring the whole process operates as expected.

  • Removal of Previous Workflow File
    The previously used go.yml file was deleted. This could significantly declutter our workflow directory and also indicates a shift in our pipeline management process.

  • Incorporation of Vulnerability Checking Workflow
    We have added an important routine to regularly check for any potential security vulnerability in our codes, improving the overall robustness of our system against malicious attacks.

  • Addition of Linting Workflow
    A new workflow for linting has been introduced. Linting helps us maintain quality code by finding and fixing issues early, subsequently enhancing code readability and reducing the chances of encountering bugs.

  • Creation of a Multi-Platform Testing Workflow
    A new workflow dedicated to running tests on various platforms was added. It allows our software to be more versatile and adaptable to different operating environments, increasing its usability for a broader set of users.

@Choraden
Copy link
Contributor

Looking at a few of the latest run actions[1] I don't really see the time benefit.

Separate actions total duration:

  • Test 1m 4s
  • E2E 7m 13s
  • Lint 23s

vs previous Go action total duration from 3 random runs:

  • 7m 4s
  • 8m 2s
  • 7m 9s

If you like the jobs being separated I'm good with it, but as you can see Test and Lint jobs time contribution to Go action are negligible.

[1] https://github.com/saucelabs/forwarder/actions

@mmatczuk
Copy link
Contributor Author

If you like the jobs being separated I'm good with it, but as you can see Test and Lint jobs time contribution to Go action are negligible.

It's just a beginning.

@mmatczuk
Copy link
Contributor Author

But I think we could join lint and test.

This allows to start e2e tests at the beginning (hopefully) reducing total checks durations.
@mmatczuk mmatczuk merged commit 0dae050 into main Dec 14, 2023
4 checks passed
@mmatczuk mmatczuk deleted the mmt/govoluncheck branch December 14, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants