Enhance CLI interface #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PoroCYon
commented
Sep 11, 2023
PoroCYon
commented
- Make archive listing (and the -l flag) work: it was documented but unimplemented (no checking for -l) and unreachable (null check made the 'no args' codepath never run) before.
- Make outputting the file to stdout optional. By default, files are now created. -o can be used to write to stdout instead.
- By default, files are written to the current directory, without recreating the full folder hierarchy of the source zip file. To create these folders, use the -f flag.
- Add a -h/--help flag to explain how to use the tool
* Make archive listing (and the -l flag) work (it was documented but unimplemented and unreachable before) * Make outputting the file to stdout optional. By default, files are now created. -o can be used to write to stdout instead. * By default, files are written to the current directory, without recreating the full folder hierarchy of the source zip file. To create these folders, use the -f flag. * Add a -h/--help flag to explain how to use the tool
|
Thanks, @PoroCYon! These changes look good to me, I'll let @anjakefala do some basic tests and merge when she confirms everything seems to work. |
anjakefala
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Tested it on .zip files here! https://www.cs.ubc.ca/labs/algorithms/Projects/autoweka/datasets/
Works as intended. =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.