[join-] fix putValue for merge rows absent in any source sheet #2647
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing cells in a MergeColumn, an error will occur if the row is absent from any of the source sheets.
putValue()
will attempt to set the value on the source sheet that does not have the row, causing an error:To reproduce this, unzip merge_rows.zip, and do
vd -p test.vdj
Then edit cells in the
source_sheet
column. The cell withsource_sheet
ofb
will have the error after you try to edit it withe
and enter any value. The cell for thea_only
row will also give the error, though the edit will succeed.This PR adds a check similar to the one in
JoinKeyColumn
:visidata/visidata/features/join.py
Lines 148 to 149 in efbe84e