Few parse_ini_config_file() fixes #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes comment misalignment.
This fixes a typo in a comment; the variable expansion intends to remove tabulation after the sign =.
The variable expansions intend to remove the tabulations before and after the sign =, as per the comment. However, the patterns match several spaces instead of a tabulation (probably because of a copy/paste at code import). This fixes the mismatch variable expansion by replacing the sequence of spaces (backslash included) by a the single quoted string composed of the ANSI escaped tabulation character (i.e. $'\t').
The removal of tabulation arround the sign = is perform by two variable expansions: - remove tabulation before the sign = - remove tabulation after the sign = This applies the same procedure to space by splitting the single removal into two variable expansions: one before the sign =, one after the sign =.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This fixes some issues found in the mechanism of ini-translation-to-bash.
I am a bit worry if the fix about the removal of (single) space before sign
=, or after sign=(but not both) and if true tabulation before and after the sign=will break things to users since it never worked.Maybe, we could simply drops that feature of stripping (single) whitespaces arround
=.What do you think?