Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method argument #844

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

manumilou
Copy link
Contributor

Tackles #842

Changes proposed in this pull request:

  • Remove deprecated argument
  • Update method documenation

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

create_batch_orders is only called once outside of tests, with the argument as true. There is no change in behaviour.

@manumilou manumilou force-pushed the remove-deprecated-method-arg branch 2 times, most recently from acd16e0 to 097428a Compare April 4, 2019 19:03
@manumilou manumilou force-pushed the remove-deprecated-method-arg branch from 097428a to dc64f4f Compare April 4, 2019 19:12
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 95.283% when pulling dc64f4f on manumilou:remove-deprecated-method-arg into 0359baf on savoirfairelinux:dev.

guillaumep pushed a commit to santropolroulant/sous-chef that referenced this pull request Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants