Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: reduce “Waiting on concurrency group” #8

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Fix: reduce “Waiting on concurrency group” #8

merged 3 commits into from
Sep 1, 2023

Commits on Aug 18, 2023

  1. fix: make deploy steps from different builds unordered 

    When setting the attribute concurrency_group on deploy steps, set concurrency_method: eager. By default (ordered), a BuildKite build’s deploy steps will wait for all the smoke_test and build steps of a previous build. This is a problem in rollbacks, which run much faster than normal builds because they have no smoke_test or build steps, so they are likely to reach their deploy steps before the previous build does.
    Yonathan Randolph committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3328a33 View commit details
    Browse the repository at this point in the history

  2. fix: Allow concurrent validation_test steps 

    Set the concurrency and concurrency_group attributes only on deploy steps, not validation_test, so that a validation_test step does not block another BuildKite build’s deploy step. Note that one build’s validation test may fail if another build deploys some other code, but that is something we will just have to be aware of when two deploys happen right after each other.
    Yonathan Randolph committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    c25c111 View commit details
    Browse the repository at this point in the history

  3. Revert "fix: Allow concurrent validation_test steps" 

    This reverts commit c25c111. This was a minor speedup and we don't need it since we can easily cancel validation test steps if necessary.
    Yonathan Randolph committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    fb9f50c View commit details
    Browse the repository at this point in the history