Allow block step #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonran
approved these changes
Oct 19, 2023
pipeline.go
Outdated
| // Block and wait steps must not contains agents or env, so we return early here | ||
| _, hasBlockStep := step["block"] | ||
| _, hasWaitStep := step["wait"] | ||
| if hasBlockStep || hasWaitStep { |
There was a problem hiding this comment.
I would call it isBlockStep and isWaitStep rather than hasBlockStep and hasWaitStep.
stanimoto
approved these changes
Oct 19, 2023
pipeline_test.go
Outdated
| t.Error("lowerStep returned err:", err) | ||
| } | ||
| if !reflect.DeepEqual(step["env"], nil) { | ||
| t.Errorf("env should not be set for a wait step") |
There was a problem hiding this comment.
nit:
Suggested change
| t.Errorf("env should not be set for a wait step") | |
| t.Errorf("env should not be set for a block step") |
pipeline_test.go
Outdated
| t.Errorf("env should not be set for a wait step") | ||
| } | ||
| if !reflect.DeepEqual(step["agents"], nil) { | ||
| t.Errorf("agents should not be set for a wait step") |
There was a problem hiding this comment.
nit:
Suggested change
| t.Errorf("agents should not be set for a wait step") | |
| t.Errorf("agents should not be set for a block step") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block step was not allowed in
.jobsworth.yml, because Jobsworth automatically adds theenvandagentsfields to every step, which are invalid fields for theblockstep.