Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug of import {} from "xxx" #3

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix the bug of import {} from "xxx" #3

merged 1 commit into from
Nov 15, 2022

Conversation

lv2020
Copy link
Contributor

@lv2020 lv2020 commented Nov 14, 2022

Sorry for the late reply. This is the fix for #1 .

@cassc
Copy link
Collaborator

cassc commented Nov 15, 2022

Thanks @lv2020!

  • Can you please add a short description about the problem and some example(s) showing the bug you solved?
  • I suppose the fix is specifically for import {X, Y, Z} from xxx only? Did you also consider other cases?

@lv2020
Copy link
Contributor Author

lv2020 commented Nov 15, 2022

  • This is for fixing the bug of incorrect segmentation of the import library. One example would be:
import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";

In the original version, you will get IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol"; as the library. In my fix, you will get @openzeppelin/contracts/token/ERC20/IERC20.sol.

  • Yes, this is only for import {X, Y, Z} from xxx. Because in my collected dataset, I only found this case.

Copy link
Collaborator

@cassc cassc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lv2020 !

@cassc cassc merged commit 879423e into sbip-sg:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants