avoid crash if deployment fail

Cargo.toml

@@ -38,6 +38,7 @@ hashbrown = "*"
 redis = { version= "0.25.4", optional = true}
 alloy = { version = "0.1.4", features = ["full"] }
 uuid = { version = "1.9.1", features = ["v4"] }
+hex-literal = "0.4.1"
 
 [dev-dependencies]
 criterion = {version="0.3.6", features=["html_reports"] }
@@ -63,4 +64,4 @@ name = "function"
 harness = false
 
 [profile.bench]
-debug = true
+debug = true

src/lib.rs

@@ -772,13 +772,11 @@ impl TinyEVM {
                 Some(force_address),
             )?;
 
-            if !resp.success {
-                // todo return reverted
-            }
-
-            if let Some(balance) = init_value {
-                let address = Address::from_slice(&resp.data);
-                self.set_account_balance(address, bigint_to_ruint_u256(&balance)?)?;
+            if resp.success {
+                if let Some(balance) = init_value {
+                    let address = Address::from_slice(&resp.data);
+                    self.set_account_balance(address, bigint_to_ruint_u256(&balance)?)?;
+                }
             }
 
             resp

tests/revm_test.rs

@@ -400,6 +400,19 @@ fn test_deterministic_deploy() {
     assert_ne!(c1.data, c2.data, "Address of c1 and c2 should not equal");
 }
 
+#[test]
+fn test_deterministic_deploy_fail() {
+    use hex_literal::hex;
+    let constructor_revert_bin = hex!("6080604052348015600f57600080fd5b600080fdfe");
+    let constructor_revert_bin = constructor_revert_bin.to_vec();
+    let mut vm = TinyEVM::default();
+    let c = vm
+        .deploy_helper(*OWNER, constructor_revert_bin.clone(), UZERO, None, None)
+        .unwrap();
+
+    assert!(!c.success, "Deploy invalid deployment binary should fail",);
+}
+
 #[test]
 fn test_deterministic_deploy_overwrite() -> Result<()> {
     setup();