Improve pageindex rebuilding; add master settings button #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e having the same background color as a standalone code block. Basically to make it look more like stackoverflow
sbrl
reviewed
Sep 5, 2024
sbrl
reviewed
Sep 5, 2024
There was a problem hiding this comment.
This is such a well thought out PR! I am touched and honoured that someone would care about my little wiki engine here enough to dedicate so much time to put together such a carefully designed pull request that matches my style of programming so well.
Given the magnitude of the change I'd like to run some tests locally myself just to double check, but then I'll get to merging!
Got one quick comment below for you too.
(this PR is ref #242)
| if(file_exists($env->storage_prefix . $pagekey) && // If it exists... | ||
| !is_dir($env->storage_prefix . $pagekey)) // ...and isn't a directory | ||
| { | ||
| // This page (potentially) has an associated file! | ||
| // Let's investigate. | ||
|
|
There was a problem hiding this comment.
Could trailing whitespace be preserved please?
sbrl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.