forked from softprops/assembly-sbt
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix newFileSystem use the URI with a non-existent path #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@eed3si9n Would you like to take a look? |
Rollback the environment settings, test was passed locally
|
eed3si9n
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This changes fixes the exact problem I am running into right now. Is there a plan for a release any time soon to publish this? |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Oct 15, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `sbt-assembly` from `2.2.0` to `2.3.0` ### Why are the changes needed? - `sbt-assembly`, the full release notes: https://github.com/sbt/sbt-assembly/releases/tag/v2.3.0 - Bug fixed: Fixes assembly not creating parent directories by Roiocam in sbt/sbt-assembly#525 Throws error when a misconfigured assemblyOutputPath is detected by hygt in sbt/sbt-assembly#523 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48409 from panbingkun/SPARK-49922. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `sbt-assembly` from `2.2.0` to `2.3.0` ### Why are the changes needed? - `sbt-assembly`, the full release notes: https://github.com/sbt/sbt-assembly/releases/tag/v2.3.0 - Bug fixed: Fixes assembly not creating parent directories by Roiocam in sbt/sbt-assembly#525 Throws error when a misconfigured assemblyOutputPath is detected by hygt in sbt/sbt-assembly#523 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48409 from panbingkun/SPARK-49922. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves: #486, #503
FileSystems don't allow you to pass the URI with a non-existent path.