First attempt at documenting serverIdleTimeout #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yea. I guess we don't yet have user-facing sbt server page, but I think this is fine for now. |
eed3si9n
reviewed
Sep 14, 2024
| @@ -332,3 +332,16 @@ This will respond back with the result of the action. | |||
| [lsp_initialize]: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#initialize | |||
| [lsp_initialized]: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#initialized | |||
| [lsp_publishdiagnosticsparams]: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#publishdiagnostics-notification | |||
|
|
|||
| ### Configuration | |||
There was a problem hiding this comment.
I think this should go immediately after the intro, like at line 17.
|
Also could you target 1.x branch for sbt 1.x documentation plz? |
lervag
force-pushed
the
serveridletimeout
branch
from
ef033f7
to
ba3bc76
Compare
|
I believe I've made the suggested changes. Should we include more options here before considering a merge? If so, are there any particular ones that seem more important? |
lervag
force-pushed
the
serveridletimeout
branch
from
78f21f7
to
5342556
Compare
I'd say ship first and we can add more later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready for merge. There are a few questions:
I would not mind completing this and perhaps try and include a few more settings when I'm at it.
Please see discussion at sbt/sbt#7631.