Patch useLocalStorage setting the right initial value to avoid a hydration error

[damianmarti]

fixes #340 (if we want to fix it with a patch to usehooks-ts)

[technophile-04]

Tysm Damu !!

This might be the problem with only my machine (even previously I had some issues picking the right dependencies) :

Screen.Recording.2023-05-30.at.11.10.38.AM.mov

I have created the useLocalStorage-patchTest branch which branches from this branch and added basic useLocalStorage to test

Step to reproduce :
1.

git pull
git switch useLocalStorage-patchTest
yarn install

2. click the greeting button on Home page( this will update isHello localStorage state to false ) and then refresh the page.

---

Now this might be the problem with only my machine so would love it if someone could test it

But, the changes look good to me 🙌

[rin-st]

It doesn't work for me too. But it works if I copy-paste hook to hooks directory and change storedValue to initialValue

And it shows initial value for some milliseconds

2023-05-30.15.25.12.mov

[damianmarti]

It doesn't work for me too. But it works if I copy-paste hook to hooks directory and change storedValue to initialValue

And it shows initial value for some milliseconds

2023-05-30.15.25.12.mov

@rin-st did you run yarn install before testing it?

[rin-st]

@damianmarti yes

I found solution: yarnpkg/berry#4231 (comment) this helped. If I change resolutions to "usehooks-ts@^2.7.2": "patch:usehooks-ts@npm:^2.7.2#./.yarn/patches/usehooks-ts-npm-2.7.2-fceffe0e43.patch" it works

[damianmarti]

@damianmarti yes

I found solution: yarnpkg/berry#4231 (comment) this helped. If I change resolutions to "usehooks-ts@^2.7.2": "patch:usehooks-ts@npm:^2.7.2#./.yarn/patches/usehooks-ts-npm-2.7.2-fceffe0e43.patch" it works

I'm not sure about it. Maybe @sverps @carletex or @technophile-04 have something to say...

[sverps]

I had the same issue as @rin-st , seems like the patch generated a faulty resolutions line (with a url-encoded ^ sign, rather than the actual one). I committed the fix from @rin-st , I think we can merge it like this 👍

[carletex]

It works! Thank you all!