Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite style guide entry on foo vs foo() #3053

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Aug 9, 2024

Note that the visibility of this will be increased by linking it to from the FAQ: #3052

review by @BalmungSan ? @Ichoran? @lrytz?

who knows, we might even nerd-snipe @djspiewak into having a look — I think he wrote the original

Copy link
Contributor

@BalmungSan BalmungSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I like the proposal. I don't like the word "side effects" tho, but I really can't think of a better word that is not a full paragraph.

Maybe something like:

Parameterless methods should not mutate the state of the called object in any way

?

@SethTisue
Copy link
Member Author

SethTisue commented Aug 9, 2024

"side effects, such as altering the receiver"?

@SethTisue SethTisue merged commit e3078bb into scala:main Aug 14, 2024
1 check passed
@SethTisue SethTisue deleted the style-guide-nullary-nilary branch August 14, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants