Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Xsource-features:double-definitions #3059

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Aug 16, 2024

@lrytz lrytz requested a review from SethTisue August 16, 2024 08:55
@SethTisue SethTisue self-assigned this Aug 16, 2024
### Changes affecting binary encoding

As of Scala 2.13.14, there are 3 changes in `-Xsource-features` that affect binary encoding of classfiles:
As of Scala 2.13.15, there are 3 changes in `-Xsource-features` that affect binary encoding of classfiles:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes — this PR will be merged at the time we release 2.13.15 (probably this week).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the "Changes affecting binary encoding" section is already online (https://docs.scala-lang.org/scala3/guides/migration/tooling-scala2-xsource3.html#changes-affecting-binary-encoding). Or was that section added too soon and not part of 2.13.14 ?

Copy link
Member

@SethTisue SethTisue Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay, now I see what you mean. 2.13.15 doesn't add any new changes affecting binary encoding. So bumping the version number is only intended to indicate that the information hasn't fallen out date, it is still accurate for 2.13.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants