Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scala3-bootstrapped/testCompilation to 'test_windows_fast' #19810

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add scala3-bootstrapped/testCompilation to 'test_windows_fast' #19810

merged 1 commit into from
Feb 28, 2024

Conversation

hamzaremmal
Copy link
Member

In light of the issue (post merge) of #19080 . We should add test compilation to windows_fast (not only windows_full).

Also see: #19802

cc @sjrd

@hamzaremmal hamzaremmal self-assigned this Feb 28, 2024
nicolasstucki
nicolasstucki suggested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to break the puropse of the test_windows_fast. With this change, it seems that test_windows_full does nothing additional to test_windows_fast. We might consider going back to a single test_windows.

We split them because the windows machine is much slower than the linux one. Testing all this in each PR might slowdown the testing pipeline.

@hamzaremmal
Copy link
Member Author

@nicolasstucki We only run testCompilation, not all of the tests

@hamzaremmal
Copy link
Member Author

I've disabled auto-merge for now

@hamzaremmal
Copy link
Member Author

test_windows_fast is still faster than test and community builds

@hamzaremmal hamzaremmal merged commit 8bcd9a9 into scala:main Feb 28, 2024
19 checks passed
@hamzaremmal hamzaremmal deleted the testcompilation-windows-fast branch February 28, 2024 16:07
@nicolasstucki
Copy link
Contributor

@nicolasstucki We only run testCompilation, not all of the tests

Right, might be fine

test_windows_fast is still faster than test and community builds

keep an eye on this when the CI is loaded to see if it behaves the same as your current observations

@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 2, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 3, 2024
@WojciechMazur
Backport "Add scala3-bootstrapped/testCompilation to 'test_windows_fa…
cc12fbb 
…st'" to LTS (#20961)

Backports #19810 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

@sjrd sjrd sjrd approved these changes

@smarter smarter Awaiting requested review from smarter

Assignees

@hamzaremmal hamzaremmal

Labels
None yet
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@hamzaremmal @nicolasstucki @sjrd @Kordyjan