-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplications of properties in pom.xml #20020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated pom.xml locally is : <?xml version='1.0' encoding='UTF-8'?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0">
<modelVersion>4.0.0</modelVersion>
<groupId>org.scala-lang</groupId>
<artifactId>scala3-compiler_3</artifactId>
<packaging>jar</packaging>
<description>scala3-compiler-bootstrapped</description>
<url>https://github.com/scala/scala3</url>
<version>3.4.2-RC1-bin-SNAPSHOT</version>
<licenses>
<license>
<name>Apache-2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0</url>
<distribution>repo</distribution>
</license>
</licenses>
<name>scala3-compiler-bootstrapped</name>
<organization>
<name>LAMP/EPFL</name>
<url>http://lamp.epfl.ch</url>
</organization>
<scm>
<url>https://github.com/scala/scala3</url>
<connection>scm:git:[email protected]:scala/scala3.git</connection>
</scm>
<developers>
<developer>
<id>odersky</id>
<name>Martin Odersky</name>
<url>https://github.com/odersky</url>
<email>[email protected]</email>
</developer>
<developer>
<id>DarkDimius</id>
<name>Dmitry Petrashko</name>
<url>https://d-d.me</url>
<email>[email protected]</email>
</developer>
<developer>
<id>smarter</id>
<name>Guillaume Martres</name>
<url>http://guillaume.martres.me</url>
<email>[email protected]</email>
</developer>
<developer>
<id>felixmulder</id>
<name>Felix Mulder</name>
<url>http://felixmulder.com</url>
<email>[email protected]</email>
</developer>
<developer>
<id>liufengyun</id>
<name>Liu Fengyun</name>
<url>https://fengy.me</url>
<email>[email protected]</email>
</developer>
<developer>
<id>nicolasstucki</id>
<name>Nicolas Stucki</name>
<url>https://github.com/nicolasstucki</url>
<email>[email protected]</email>
</developer>
<developer>
<id>OlivierBlanvillain</id>
<name>Olivier Blanvillain</name>
<url>https://github.com/OlivierBlanvillain</url>
<email>[email protected]</email>
</developer>
<developer>
<id>biboudis</id>
<name>Aggelos Biboudis</name>
<url>http://biboudis.github.io</url>
<email>[email protected]</email>
</developer>
<developer>
<id>allanrenucci</id>
<name>Allan Renucci</name>
<url>https://github.com/allanrenucci</url>
<email>[email protected]</email>
</developer>
<developer>
<id>Duhemm</id>
<name>Martin Duhem</name>
<url>https://github.com/Duhemm</url>
<email>[email protected]</email>
</developer>
</developers>
<properties>
<scala.versionLine>Next</scala.versionLine>
</properties>
<dependencies>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala3-interfaces</artifactId>
<version>3.4.2-RC1-bin-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala3-library_3</artifactId>
<version>3.4.2-RC1-bin-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>tasty-core_3</artifactId>
<version>3.4.2-RC1-bin-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>com.github.sbt</groupId>
<artifactId>junit-interface</artifactId>
<version>0.13.3</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.scala-lang.modules</groupId>
<artifactId>scala-asm</artifactId>
<version>9.6.0-scala-1</version>
</dependency>
<dependency>
<groupId>org.scala-sbt</groupId>
<artifactId>compiler-interface</artifactId>
<version>1.9.6</version>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-reader</artifactId>
<version>3.25.1</version>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-terminal</artifactId>
<version>3.25.1</version>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-terminal-jna</artifactId>
<version>3.25.1</version>
</dependency>
<dependency>
<groupId>io.get-coursier</groupId>
<artifactId>coursier_2.13</artifactId>
<version>2.0.16</version>
<scope>test</scope>
</dependency>
</dependencies>
</project> |
It also appends the properties. For <?xml version='1.0' encoding='UTF-8'?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0">
<modelVersion>4.0.0</modelVersion>
<groupId>org.scala-lang</groupId>
<artifactId>scala3-library_3</artifactId>
<packaging>jar</packaging>
<description>scala3-library-bootstrapped</description>
<url>https://github.com/scala/scala3</url>
<version>3.4.2-RC1-bin-SNAPSHOT</version>
<licenses>
<license>
<name>Apache-2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0</url>
<distribution>repo</distribution>
</license>
</licenses>
<name>scala3-library-bootstrapped</name>
<organization>
<name>LAMP/EPFL</name>
<url>http://lamp.epfl.ch</url>
</organization>
<scm>
<url>https://github.com/scala/scala3</url>
<connection>scm:git:[email protected]:scala/scala3.git</connection>
</scm>
<developers>
<developer>
<id>odersky</id>
<name>Martin Odersky</name>
<url>https://github.com/odersky</url>
<email>[email protected]</email>
</developer>
<developer>
<id>DarkDimius</id>
<name>Dmitry Petrashko</name>
<url>https://d-d.me</url>
<email>[email protected]</email>
</developer>
<developer>
<id>smarter</id>
<name>Guillaume Martres</name>
<url>http://guillaume.martres.me</url>
<email>[email protected]</email>
</developer>
<developer>
<id>felixmulder</id>
<name>Felix Mulder</name>
<url>http://felixmulder.com</url>
<email>[email protected]</email>
</developer>
<developer>
<id>liufengyun</id>
<name>Liu Fengyun</name>
<url>https://fengy.me</url>
<email>[email protected]</email>
</developer>
<developer>
<id>nicolasstucki</id>
<name>Nicolas Stucki</name>
<url>https://github.com/nicolasstucki</url>
<email>[email protected]</email>
</developer>
<developer>
<id>OlivierBlanvillain</id>
<name>Olivier Blanvillain</name>
<url>https://github.com/OlivierBlanvillain</url>
<email>[email protected]</email>
</developer>
<developer>
<id>biboudis</id>
<name>Aggelos Biboudis</name>
<url>http://biboudis.github.io</url>
<email>[email protected]</email>
</developer>
<developer>
<id>allanrenucci</id>
<name>Allan Renucci</name>
<url>https://github.com/allanrenucci</url>
<email>[email protected]</email>
</developer>
<developer>
<id>Duhemm</id>
<name>Martin Duhem</name>
<url>https://github.com/Duhemm</url>
<email>[email protected]</email>
</developer>
</developers>
<properties>
<scala.versionLine>Next</scala.versionLine>
<info.versionScheme>semver-spec</info.versionScheme>
</properties>
<dependencies>
<dependency>
<groupId>com.github.sbt</groupId>
<artifactId>junit-interface</artifactId>
<version>0.13.3</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
<version>2.13.12</version>
</dependency>
</dependencies>
</project> |
Kordyjan
approved these changes
Mar 26, 2024
WojciechMazur
added a commit
that referenced
this pull request
Jul 5, 2024
Backports #20020 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by how to add release notes URL : https://contributors.scala-lang.org/t/add-release-notes-urls-to-your-poms/6059
Closes #20016