Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Fix implicit search failure reporting" to LTS #21089

Merged
merged 4 commits into from
Jul 6, 2024
Merged

Backport "Fix implicit search failure reporting" to LTS #21089

merged 4 commits into from
Jul 6, 2024

Commits on Jul 6, 2024

  1. Fix implicit search failure reporting 

    [Cherry-picked fc06435]
    @mbovel @WojciechMazur
    mbovel authored and WojciechMazur committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0b8dc35 View commit details
    Browse the repository at this point in the history

  2. Type addImplicitsArgs result with the first failure 

    [Cherry-picked 0890e7a]
    @mbovel @WojciechMazur
    mbovel authored and WojciechMazur committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    520e548 View commit details
    Browse the repository at this point in the history

  3. Do not visit args recursively in issueErrors 

    Instead, fix the display of nested `AmbiguousImplicits` errors.

[Cherry-picked 0e4d51a][modified]
    @WojciechMazur
    WojciechMazur committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    4b84055 View commit details
    Browse the repository at this point in the history

  4. Output "no best given instance" for ambiguous implicit error messages 

    [Cherry-picked ebf58bb]
    @mbovel @WojciechMazur
    mbovel authored and WojciechMazur committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    a04403c View commit details
    Browse the repository at this point in the history