Simple performance improvement for Denotations #21584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple performance improvement extracted from #21278
This PR:
cachessignature
inSingleDenotation
formatchDegree
;denot
calls inwiden
s.This is a simpler approach which can reduce the compilation time of #20217 from 60s to about
20s40s.I revert the signature cache to keep this PR simple, because I don't understand why it works.