Optimise SpaceEngine.signature #21791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `constrained` on a TypeLambda means adding one TypeLambda for all the type parameters in tp1, while newTypeVar creates a TypeLambda for each type parameter.
Instead of creating type vars, constraining against them, then instantiating them, just instantiate the PolyType with the scrutinee type args (or the lo/hi bound or bounded wildcard from the param).
|
I've run the OpenCB against these changes. So far there seems to be no new regressions since last nightly. |
|
@lrytz I dropped the extra special handling, happy to approve this now? |
|
"may my presence forever slow your build" is one of the lesser known Halloween curses, but there you have it. Hopefully this annoys somebody enough to look into why the compilation performance regressed so much in the first place vs Scala 2, not just for this recent change. Or is this now expected to have Scala 2 levels of perf? Probably these test files need some attribution on them, since they are so big, but I don't feel like I'm so proud enough of them to push for that. Have fun. |
Gedochao
added
the
backport:nominated
|
@WojciechMazur should we backport this to 3.6.2? |
WojciechMazur
added a commit
that referenced
this pull request
Nov 8, 2024
Backports #21791 to the 3.6.2 branch. PR submitted by the release tooling. [skip ci]
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21569