Improve, document and group versioning code in Build.scala
#21837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: with change to Edit: |
…orkaround wix limitations
…s triggered by tag
WojciechMazur
force-pushed
the
build/improve-versions
branch
from
d6367fd
to
af7ff5b
Compare
hamzaremmal
approved these changes
Nov 5, 2024
| # NECESSARY FLAG TO CORRECTLY CONFIGURE THE VERSION FOR SCALA | ||
| RELEASEBUILD: yes | ||
| # Release only happends when triggering CI by pushing tag | ||
| RELEASEBUILD: ${{ startsWith(github.event.ref, 'refs/tags/') && 'yes' || 'no' }} |
There was a problem hiding this comment.
Should be fine since the payload in the reusable workflow is inherited from the caller (See https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_call)
There was a problem hiding this comment.
I've tested it in a custom repo, it worked as expected
WojciechMazur
added
the
backport:nominated
WojciechMazur
added a commit
that referenced
this pull request
Nov 6, 2024
…21837) * Introduce `developedVersion` describing the target for the current release cycle * Adapt `baseVersion` to the effectively revert #21011 changes * Adapt .msi packager to use `developedVersion` as a workaround to MSI ProductInfo limitations (version without RC suffix required) * Group and document versioning related code [Cherry-picked 11c957c][modified]
WojciechMazur
added a commit
that referenced
this pull request
Nov 6, 2024
…21837) * Introduce `developedVersion` describing the target for the current release cycle * Adapt `baseVersion` to the effectively revert #21011 changes * Adapt .msi packager to use `developedVersion` as a workaround to MSI ProductInfo limitations (version without RC suffix required) * Group and document versioning related code [Cherry-picked 11c957c][modified]
WojciechMazur
added a commit
that referenced
this pull request
Nov 6, 2024
…21837) * Introduce `developedVersion` describing the target for the current release cycle * Adapt `baseVersion` to the effectively revert #21011 changes * Adapt .msi packager to use `developedVersion` as a workaround to MSI ProductInfo limitations (version without RC suffix required) * Group and document versioning related code [Cherry-picked 11c957c][modified]
WojciechMazur
added a commit
that referenced
this pull request
Nov 6, 2024
…21837) * Introduce `developedVersion` describing the target for the current release cycle * Adapt `baseVersion` to the effectively revert #21011 changes * Adapt .msi packager to use `developedVersion` as a workaround to MSI ProductInfo limitations (version without RC suffix required) * Group and document versioning related code [Cherry-picked 11c957c][modified]
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developedVersiondescribing the target for the current release cyclebaseVersionto the effectively revert Set baseVersion to 3.6.0 instead of 3.6.0-RC1 #21011 changesdevelopedVersionas a workaround to MSI ProductInfo limitations (version without RC suffix required)Fixes #21821
Resolves #21812
[test_msi]