-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isScratch banner #8296
base: master
Are you sure you want to change the base?
Remove isScratch banner #8296
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)CHANGELOG.unreleased.md (1)
The changelog entry is clear, follows the proper format, and accurately describes the removal of the scratch volume warning feature. It's appropriately placed in the "Removed" section and includes the correct PR reference. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works for me too :) Thanks!
Could you add a changelog entry?
@@ -401,7 +374,6 @@ function mapStateToProps(state: OxalisState) { | |||
isUpdateTracingAllowed: state.tracing.restrictions.allowUpdate, | |||
showVersionRestore: state.uiInformation.showVersionRestore, | |||
storedLayouts: state.uiInformation.storedLayouts, | |||
isDatasetOnScratchVolume: state.dataset.dataStore.isScratch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also remove the property from the frontend as this is the onliest place where it is actively used?
Hasn't been used in 5 years.