-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scalameta to 4.9.9 #2024
Conversation
16ef2c1
to
99c0235
Compare
Previously breaking since 4.9.4 Improvements
Changes breaking for implementation (but not passed onto the Scalafix API clients)
Breaking changes (passed onto the Scalafix API clients) |
6d71b94
to
4de7c67
Compare
4de7c67
to
caaf6b1
Compare
scalameta | ||
scalameta, | ||
// CrossVersion.for3Use2_13 would only lookup a binary version artifact, but this is published with full version | ||
semanticdbScalacCore.cross(CrossVersion.constant(scala213)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following scalameta/scalameta#3747, this was added to continue building against internal.{symtab,metap}
(now directly via semanticdb-scalac-core) & protobuf stubs in internal.semanticdb
(now transitively via semanticb-shared). Unfortunately, this brings way too much stuff: `scala.meta.interactive, other unused (internal) classes, and the Scala2 compiler itself.
If this turns out to be a problem, we could either (1) revisit this upstream, or (2) rely on semanticdb-shared and shade only packages we need from semanticdb-scalac-core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest problem here I guess is that we are using internal packages, we should move them out of internal if they are intended to be binary compat or as you suggest shade them in scalafix π€
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I will go for (2). For the record: I'll wait for the next scalameta release I guess (since I am effectively blocked by scalameta/scalameta#3786 (comment)), where semanticdb-shared will be cross-built with binary version only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was not that easy in the end :( #2048
About this PR
π¦ Updates org.scalameta:scalameta from
4.9.3
to4.9.9
π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: