Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecated vim.lsp.util._trim #618

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: deprecated vim.lsp.util._trim #618

merged 1 commit into from
Oct 11, 2023

Conversation

vanhtuan0409
Copy link
Contributor

fix: #617

ckipp01
ckipp01 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @vanhtuan0409! The CI is failing, but that's not due to this change. There is something funky going on with the decorations modules with nightly that I need to figure out. LGTM

@ckipp01 ckipp01 merged commit 136a543 into scalameta:main Oct 11, 2023
4 of 5 checks passed
@vanhtuan0409 vanhtuan0409 deleted the lsputil branch October 12, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run MetalsInfo on nightly
2 participants
@vanhtuan0409 @ckipp01