Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile benchmark directory #859

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Compile benchmark directory #859

merged 5 commits into from
Jul 1, 2024

Conversation

bwignall
Copy link
Contributor

@bwignall bwignall commented Jul 1, 2024

The benchmark directory was not compiling on a fresh checkout. Some of this was because of changes to the Google Caliper dependency, some to Breeze APIs in the "root" directories, some other.

The benchmark directory now compiles cleanly, locally.

Copy link
Member

@dlwh dlwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, yeah I stopped running these on the regular. If you wanted to make some fast version of them run in CI that might be a good idea?

(As you can probably tell, Breeze is maintainence-mode with me flirting pressing the "archive this project" button. I haven't written non-trivial scala for 2.5 years.)

@bwignall
Copy link
Contributor Author

bwignall commented Jul 1, 2024

I must admit that I haven't tried running the benchmarks themselves, so I don't have an immediate sense for how to run a fast version. How about the following? I add a CI step in the existing config, to add a benchmark / compile checking step, and I save the updated runs for a separate PR?

@dlwh
Copy link
Member

dlwh commented Jul 1, 2024

sure that's great. I'm gonna merge this as-is if you want to follow up with more PR's, please lmk!

@dlwh dlwh merged commit 4a3ecdd into scalanlp:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants