Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-ci-testing #193

Merged
merged 33 commits into from
Dec 3, 2023
Merged

update-ci-testing #193

merged 33 commits into from
Dec 3, 2023

Conversation

itziakos
Copy link
Contributor

Add more recent python version on ci testing

Add more recent python version on ci testing
@itziakos itziakos marked this pull request as draft November 12, 2023 14:08
@itziakos
Copy link
Contributor Author

itziakos commented Nov 12, 2023

@sjagoe I am trying to get the github tests to run, but I think I am doing something wrong. Can you have have a look when you have some spare time?

removed deprecated runners
fix typo for the macos runners name
- Add cp312 config
- Add cp311 config
- Fix cp310 config
simplify test matrix
fix workflow
run lint action first
.github/workflows/test.yml Outdated Show resolved Hide resolved
@sjagoe
Copy link
Member

sjagoe commented Nov 26, 2023

I can run tests locally if I run from a different directory. If I run from the git checkout directory, I get the same errors 🤔

@itziakos
Copy link
Contributor Author

I can run tests locally if I run from a different directory. If I run from the git checkout directory, I get the same errors 🤔

I suspect we get some weird PYTHONPATH interference. I am going to have a closer look

@sjagoe
Copy link
Member

sjagoe commented Nov 26, 2023

I can run tests locally if I run from a different directory

I think that's what tox was doing as well; running from a different location.

@sjagoe
Copy link
Member

sjagoe commented Nov 26, 2023

when haas is a directory in the current working directory, running python -m unittest discover haas will interpret haas as a directory name and add it to sys.path

I think it's a unittest limitation and that's partly why tox was used to run in a different directory. We can just create an empty dir and use it as working_directory in the run tests step

python -m haas haas runs tests as expected even when run from the level above the package :)

.github/workflows/test.yml Outdated Show resolved Hide resolved
@itziakos
Copy link
Contributor Author

when haas is a directory in the current working directory, running python -m unittest discover haas will interpret haas as a directory name and add it to sys.path

I think it's a unittest limitation and that's partly why tox was used to run in a different directory. We can just create an empty dir and use it as working_directory in the run tests step

python -m haas haas runs tests as expected even when run from the level above the package :)

Done :P

.github/workflows/test.yml Outdated Show resolved Hide resolved
@itziakos
Copy link
Contributor Author

itziakos commented Nov 26, 2023

@sjagoe it looks that testing is now working as expected. I will try to fix the real errors next and revisit the setup before I request a final review.

@sjagoe

This comment was marked as resolved.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@itziakos itziakos marked this pull request as ready for review December 3, 2023 16:23
@itziakos itziakos merged commit 9f8126c into master Dec 3, 2023
25 checks passed
@itziakos itziakos deleted the fix-support-for-recent-python-versions branch December 3, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants