Fix macos test discovery path resolution and drop python 2 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjagoe
changed the base branch from
master
to
fix-support-for-recent-python-versions
This comment was marked as resolved.
This comment was marked as resolved.
sjagoe
force-pushed
the
drop-python-2
branch
6 times, most recently
from
921ce4d to
1a9df30
Compare
sjagoe
changed the title
sjagoe
merged commit 27b8185
into
fix-support-for-recent-python-versions
25 checks passed
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Python 2 support and use updated unittest methods for Python 3.12.
I don't understand the macos failuresMacos was resolving some absolute paths as
/private/var/...and others as/var/...; it seems one is a symlink to the other, but the paths are obviously different.Using
pathlibto resolve paths fixes this as it follows symlinks when normalizing.