systemd: fix error thrown by 'sed' in scw-set-hostname #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, that's what I get for not paying enough attention to manpage contents... However, now that I looked, I see that we could just set |
|
Let's do both, because I don't quite trust the output altogether. The check I've originally introduced is cheap enough, I believe. I'll push a change to this PR later today. |
`hostnamectl` can return more than one hostname, the pair "transient"
and "static" hostname is not uncommon.
The script then fails because `$old_hostname` is set to two lines (!)
with the first being "n/a". Both get passed to `sed` and result in an
invalid script both ways, because `grep` finds it erroneously due to
its special meaning.
In that case a `hostnamectl --static` won't return 'localhost',
but is indeed empty.
Just assume it's not in /etc/hosts in those cases and stick to writing
the new hostname.
|
I am here for you if you have any questions! |
|
Any way to move this forward? |
|
How can we land this, any changes you'd like to see? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hostnamectlcan return more than one hostname, the pair "transient"and "static" hostname is not uncommon.
The script then fails because
$old_hostnameis set to two lines (!)with the first being "n/a". Both get passed to
sedand result in aninvalid script both ways, because
grepfinds it erroneously due toits special meaning.
Just assume it's not in /etc/hosts